Chore(tabulation): Keydown refactor #79

e11sy · 2024-08-09T19:30:42Z

This PR is related to the #75 issue
This PR is a part of global work on List 2.0

Problems

Nesting works incorrectly

If user presses shift + tab, then item moves to the bottom of sublist
On shift + tab, item should decrease own nesting level and nesting level of the sublist
On tab only one current item should increase nesting level

List could not be splitted (check Split list on enter in empty item #30)
List items are not moveable (with pressed Alt)

Solutions

Refactor keydown behaviour

Status

Refactor keydowns befaviour
List splitting for Split list on enter in empty item #30
Support list and list item merging
Add special behaviour for Alt + Up, Alt + Down (optional)

Additional

Refactored the architecture
Now NestedList class initializes all types of renderers and passes them to tabulator

in next pull request i will make nesting and ordered list customization

src/ListTabulator/index.ts

src/index.ts

src/ListTabulator/index.ts

- improved docs - get rid of level usage in renderers and tabulator - improved naming

src/ListTabulator/index.ts

- added mergeCurrentItemWithPrevious method - added splitItem method - added splitList method

src/ListTabulator/index.ts

src/types/ListRenderer.ts

src/ListRenderer/ListRenderer.ts

src/ListRenderer/ChecklistRenderer.ts

src/ListRenderer/OrderedListRenderer.ts

src/ListRenderer/UnorderedListRenderer.ts

src/ListTabulator/index.ts

src/utils/getChildItems.ts

src/utils/getItemChildWrapper.ts

src/utils/isLastItem.ts

src/utils/itemHasSublist.ts

src/utils/removeChildWrapperIfEmpty.ts

src/utils/getSiblings.ts

e11sy added 4 commits August 9, 2024 20:48

refactored tab and shift+tab nehaviour

22922cb

tab fix

faba066

now list could be splitted in the middle on enter

1083cf1

comments improved

787d03e

e11sy changed the base branch from main to release/2.0 August 9, 2024 19:32

e11sy added 8 commits August 9, 2024 22:44

split corner case fixed

d0d1852

fix enter behaviour

8dd7b56

replace some of the utils with @editorjs/utils packages

01e4788

refactored item merging behaviour

128655a

clean up

d38c568

blocks merge implemented

158bcd2

now nested list passes initialized renderer to the tabulator

8977973

moved to types

0d65f0a

e11sy requested a review from neSpecc September 10, 2024 13:56

neSpecc reviewed Sep 10, 2024

View reviewed changes

e11sy added 6 commits September 11, 2024 22:21

merge method added

9549e90

refactor merge lists

a2a9090

renaming and comments improvements

96f07a6

now new instance of tabulator is created on convertion

b71cef8

codestyle

1267fa3

renaming

b64470a

neSpecc reviewed Sep 17, 2024

View reviewed changes

removed currentLevel from tabulator

358ac9e

- improved docs - get rid of level usage in renderers and tabulator - improved naming

neSpecc reviewed Sep 18, 2024

View reviewed changes

src/ListTabulator/index.ts Outdated Show resolved Hide resolved

src/ListTabulator/index.ts Outdated Show resolved Hide resolved

src/ListTabulator/index.ts Outdated Show resolved Hide resolved

src/ListTabulator/index.ts Outdated Show resolved Hide resolved

e11sy added 3 commits September 24, 2024 01:10

fix paragraph insertion bug

8d2d555

improved responsibilities of enterpressed and backspace

227644e

- added mergeCurrentItemWithPrevious method - added splitItem method - added splitList method

codestyle improvement

4e76dc7

neSpecc reviewed Sep 25, 2024

View reviewed changes

suggestions

f72e54f

neSpecc reviewed Sep 25, 2024

View reviewed changes

e11sy added 3 commits September 25, 2024 22:32

caret alias added

d0518f0

comments improved

01efb29

typo fixed

2e43690

neSpecc reviewed Sep 25, 2024

View reviewed changes

src/ListTabulator/index.ts Show resolved Hide resolved

added utils for code readability

b6249b9

neSpecc reviewed Sep 28, 2024

View reviewed changes

e11sy added 3 commits September 28, 2024 19:52

fixed merge item logic

6de4e14

build fix and comments improved

740ceef

get child items could not return null now

eee722a

neSpecc reviewed Sep 28, 2024

View reviewed changes

src/utils/getSiblings.ts Outdated Show resolved Hide resolved

e11sy added 2 commits September 28, 2024 20:08

changed getSiblings util

a9009ee

fix bug

16abb05

neSpecc approved these changes Sep 28, 2024

View reviewed changes

e11sy merged commit 11dd1b6 into release/2.0 Sep 28, 2024
1 check passed

neSpecc deleted the keydown-refactor branch September 28, 2024 17:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore(tabulation): Keydown refactor #79

Chore(tabulation): Keydown refactor #79

e11sy commented Aug 9, 2024 •

edited

Loading

Chore(tabulation): Keydown refactor #79

Chore(tabulation): Keydown refactor #79

Conversation

e11sy commented Aug 9, 2024 • edited Loading

Problems

Solutions

Status

Additional

e11sy commented Aug 9, 2024 •

edited

Loading